[webkit-reviews] review granted: [Bug 227464] Encoding specified in the 'charset' attribute should have precedence over 'content' attribute : [Attachment 432444] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Qiaosong Zhou
<qiaosong_zhou at apple.com>'s request for review:
Bug 227464: Encoding specified in the 'charset' attribute should have
precedence over 'content' attribute
https://bugs.webkit.org/show_bug.cgi?id=227464

Attachment 432444: Patch

https://bugs.webkit.org/attachment.cgi?id=432444&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 432444
  --> https://bugs.webkit.org/attachment.cgi?id=432444
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432444&action=review

r=me

> Source/WebCore/ChangeLog:9
> +	   (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes):

It's nice to write a little explanation here about what made the previous logic
incorrect, and how the new logic corrects it. Even if the case is pretty simple
like this one.