[webkit-reviews] review granted: [Bug 227462] Nullptr crash in ResourceLoadStatisticsDatabaseStore::allAttributedPrivateClickMeasurement : [Attachment 432427] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 28 15:01:55 PDT 2021
Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 227462: Nullptr crash in
ResourceLoadStatisticsDatabaseStore::allAttributedPrivateClickMeasurement
https://bugs.webkit.org/show_bug.cgi?id=227462
Attachment 432427: Patch
https://bugs.webkit.org/attachment.cgi?id=432427&action=review
--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 432427
--> https://bugs.webkit.org/attachment.cgi?id=432427
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=432427&action=review
>
Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp
:3509
> + return attributions;
Darin told me in the past to return { }; in such cases and not move the
variable declaration so I am passing along the comment :)
More information about the webkit-reviews
mailing list