[webkit-reviews] review granted: [Bug 227453] Live Text selections inside images is misaligned when "object-fit" is not "fill" : [Attachment 432414] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 227453: Live Text selections inside images is misaligned when "object-fit"
is not "fill"
https://bugs.webkit.org/show_bug.cgi?id=227453

Attachment 432414: Patch

https://bugs.webkit.org/attachment.cgi?id=432414&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432414
  --> https://bugs.webkit.org/attachment.cgi?id=432414
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432414&action=review

> Source/WebCore/html/HTMLElement.cpp:1466
> +    document().updateLayoutIfDimensionsOutOfDate(*this);

I don't think this is the right kind of layout? I think you want the normal
update-if-needed-recursively