[webkit-reviews] review granted: [Bug 227210] [Cocoa] Migrate WebRTC UDP socket handling to NW API : [Attachment 431958] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 227210: [Cocoa] Migrate WebRTC UDP socket handling to NW API
https://bugs.webkit.org/show_bug.cgi?id=227210

Attachment 431958: Patch

https://bugs.webkit.org/attachment.cgi?id=431958&action=review




--- Comment #11 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 431958
  --> https://bugs.webkit.org/attachment.cgi?id=431958
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431958&action=review

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.h:2
> + * Copyright (C) 2020 Apple Inc. All rights reserved.

Nit: should this be 2021?

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:2
> + * Copyright (C) 2020 Apple Inc. All rights reserved.

Ditto

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm:74
> +	   if (error)
> +	       return;

Is it worth logging this error?