[webkit-reviews] review denied: [Bug 227436] Change static funtion to extern in KeywordLookup.h. : [Attachment 432366] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 28 10:33:17 PDT 2021

Michael Catanzaro <mcatanzaro at gnome.org> has denied Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 227436: Change static funtion to extern in KeywordLookup.h.

Attachment 432366: Patch


--- Comment #5 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 432366
  --> https://bugs.webkit.org/attachment.cgi?id=432366

View in context: https://bugs.webkit.org/attachment.cgi?id=432366&action=review

>>> Source/JavaScriptCore/parser/Lexer.cpp:788
>>> +ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar c)
>> Problem is using ALWAYS_INLINE for a function that's not defined in the
header doesn't make sense. We need to either:
>>  (a) Also remove ALWAYS_INLINE, or
>>  (b) Move the definitions of these functions to KeywordLookup.h (which is
generated by KeywordLookupGenerator.py)
> Please do not remove ALWAYS_INLINE. They are *super* critical
performance-sensitive function, and removing that can cause severe perf impact
on several benchmarks.

Let's do (b) then.

More information about the webkit-reviews mailing list