[webkit-reviews] review granted: [Bug 227448] [Model] [iOS] Add support for manipulating <model> inline : [Attachment 432392] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 227448: [Model] [iOS] Add support for manipulating <model> inline
https://bugs.webkit.org/show_bug.cgi?id=227448

Attachment 432392: Patch

https://bugs.webkit.org/attachment.cgi?id=432392&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432392
  --> https://bugs.webkit.org/attachment.cgi?id=432392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432392&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:74
> +	       if ([view isKindOfClass:[WKModelView class]])
> +		   return true;

I would expect this to be a WKNativelyInteractible check too?

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:293
> +	   if ([view isKindOfClass:[WKModelView class]])
> +	       return view;

Why does WKNativelyInteractible not do the trick?

> Source/WebKit/UIProcess/ios/WKModelInteractionGestureRecognizer.mm:60
> +    auto finalTouchesEnded = [touches isEqualToSet:[event
touchesForGestureRecognizer:self]];
> +    [self setState:finalTouchesEnded ? UIGestureRecognizerStateEnded :
UIGestureRecognizerStateChanged];

What's this weirdness about? (why not just pass the event type along? Are you
sure this never means you don't get Ended?