[webkit-reviews] review denied: [Bug 226557] -Warray-bounds warning in Packed.h : [Attachment 432395] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has denied Michael Catanzaro
<mcatanzaro at gnome.org>'s request for review:
Bug 226557: -Warray-bounds warning in Packed.h
https://bugs.webkit.org/show_bug.cgi?id=226557

Attachment 432395: Patch

https://bugs.webkit.org/attachment.cgi?id=432395&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 432395
  --> https://bugs.webkit.org/attachment.cgi?id=432395
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432395&action=review

> Source/WTF/wtf/Packed.h:149
> +IGNORE_WARNINGS_BEGIN("stringop-overread")

It doesn't work. GCC is just ignoring the pragma.

We might have to rewrite this code.