[webkit-reviews] review granted: [Bug 227392] [Model] [iOS] Add support for rendering model resources : [Attachment 432329] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 26 15:24:31 PDT 2021
Tim Horton <thorton at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 227392: [Model] [iOS] Add support for rendering model resources
https://bugs.webkit.org/show_bug.cgi?id=227392
Attachment 432329: Patch
https://bugs.webkit.org/attachment.cgi?id=432329&action=review
--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432329
--> https://bugs.webkit.org/attachment.cgi?id=432329
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=432329&action=review
> Source/WTF/ChangeLog:11
> + 12 SDKs, but ultimately we will only use the iOS version check.
12?
> Source/WebKit/UIProcess/ios/WKModelView.mm:81
> + [_preview setupRemoteConnectionWithCompletionHandler:^(NSError *
_Nullable contextError) {
Your infectious nullables are still here
More information about the webkit-reviews
mailing list