[webkit-reviews] review denied: [Bug 227420] RELEASE_ASSERT hit in NetworkSessionCocoa::removeWebSocketTask when using WKWebViewConfiguration._attributedBundleIdentifier : [Attachment 432321] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 26 08:17:10 PDT 2021


Alex Christensen <achristensen at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227420: RELEASE_ASSERT hit in NetworkSessionCocoa::removeWebSocketTask when
using WKWebViewConfiguration._attributedBundleIdentifier
https://bugs.webkit.org/show_bug.cgi?id=227420

Attachment 432321: Patch

https://bugs.webkit.org/attachment.cgi?id=432321&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 432321
  --> https://bugs.webkit.org/attachment.cgi?id=432321
Patch

This is close but not quite correct if a NetworkSocketChannel is using the
default session set.  I think we are going to need to have NetworkSocketChannel
keep a WeakPtr to the SessionSet.


More information about the webkit-reviews mailing list