[webkit-reviews] review granted: [Bug 227385] [macOS] -[NSString _web_widthWithFont:] returns 0 : [Attachment 432303] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 25 16:20:05 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 227385: [macOS] -[NSString _web_widthWithFont:] returns 0
https://bugs.webkit.org/show_bug.cgi?id=227385

Attachment 432303: Patch

https://bugs.webkit.org/attachment.cgi?id=432303&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 432303
  --> https://bugs.webkit.org/attachment.cgi?id=432303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432303&action=review

> Tools/TestWebKitAPI/Tests/mac/StringWidth.mm:38
> +    EXPECT_GE(result, 3);

3 seems a little small?


More information about the webkit-reviews mailing list