[webkit-reviews] review denied: [Bug 227403] [GStreamer][EME] Fix resources release when a MediaKeySession is closed : [Attachment 432273] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 227403: [GStreamer][EME] Fix resources release when a MediaKeySession is
closed
https://bugs.webkit.org/show_bug.cgi?id=227403

Attachment 432273: Patch

https://bugs.webkit.org/attachment.cgi?id=432273&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 432273
  --> https://bugs.webkit.org/attachment.cgi?id=432273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432273&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:589
> -    if (!m_session || m_sessionID.isEmpty() ||
opencdm_session_update(m_session.get(), response->data(), response->size()))
> +    if (!m_session || m_sessionID.isEmpty() ||
opencdm_session_update(m_session->get(), response->dataAsUInt8Ptr(),
response->size()))

dataAsUInt8Ptr does not exist anymore. Please revert this part.