[webkit-reviews] review granted: [Bug 227395] [css-flexbox] Improve computation of intrinsic sizes of flex items with aspect ratio : [Attachment 432267] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 25 07:40:47 PDT 2021


Rob Buis <rbuis at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 227395: [css-flexbox] Improve computation of intrinsic sizes of flex items
with aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=227395

Attachment 432267: Patch

https://bugs.webkit.org/attachment.cgi?id=432267&action=review




--- Comment #2 from Rob Buis <rbuis at igalia.com> ---
Comment on attachment 432267
  --> https://bugs.webkit.org/attachment.cgi?id=432267
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432267&action=review

> Source/WebCore/ChangeLog:12
> +	   sizes mentioned in the specs
https://drafts.csswg.org/css-flexbox/#definite-sizes.

Would do "in the specs, see http:....", "in the specs (http:....)" or make a
footnote [1].


More information about the webkit-reviews mailing list