[webkit-reviews] review granted: [Bug 227386] Fix null crash in AudioMediaStreamTrackRendererCocoa::start : [Attachment 432240] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 25 05:06:48 PDT 2021
youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227386: Fix null crash in AudioMediaStreamTrackRendererCocoa::start
https://bugs.webkit.org/show_bug.cgi?id=227386
Attachment 432240: Patch
https://bugs.webkit.org/attachment.cgi?id=432240&action=review
--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 432240
--> https://bugs.webkit.org/attachment.cgi?id=432240
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=432240&action=review
> Source/WebCore/ChangeLog:11
> + has an early return or hasn't been called yet.
It probably means we have an early return, which means we have an error case
when creating the audio unit.
Release logging would tell us what actually happened.
More information about the webkit-reviews
mailing list