[webkit-reviews] review denied: [Bug 227344] [GTK][WPE] Check Gapplication has a valid ID before trying to create the flatpack info : [Attachment 432145] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 24 13:40:14 PDT 2021
Michael Catanzaro <mcatanzaro at gnome.org> has denied review:
Bug 227344: [GTK][WPE] Check Gapplication has a valid ID before trying to
create the flatpack info
https://bugs.webkit.org/show_bug.cgi?id=227344
Attachment 432145: Patch
https://bugs.webkit.org/attachment.cgi?id=432145&action=review
--- Comment #3 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 432145
--> https://bugs.webkit.org/attachment.cgi?id=432145
Patch
Patrick noticed that this will cause portals to think the application is not
sandboxed.
We should instead replaced the early return with a g_error() explaining that
the sandbox cannot be used without running a GApplication instance with a valid
app ID.
More information about the webkit-reviews
mailing list