[webkit-reviews] review granted: [Bug 223593] Resync web-platform-tests/css/css-grid tests from upstream : [Attachment 432032] Patch

[bugzilla-daemon at webkit.org]

Manuel Rego Casasnovas <rego at igalia.com> has granted zsun at igalia.com's request
for review:
Bug 223593: Resync web-platform-tests/css/css-grid tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=223593

Attachment 432032: Patch

https://bugs.webkit.org/attachment.cgi?id=432032&action=review




--- Comment #9 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 432032
  --> https://bugs.webkit.org/attachment.cgi?id=432032
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432032&action=review

r=me

> LayoutTests/ChangeLog:8
> +	   * TestExpectations:

Nit: I think you miss the iOS TestExpecations file linked here.

> LayoutTests/TestExpectations:1221
>
+imported/w3c/web-platform-tests/css/css-grid/abspos/grid-abspos-staticpos-alig
n-self-002.html [ ImageOnlyFailure ]

It'd be really nice to associate these with some bugs. Some are related to
alignment and baseline, so a bunch of them could point to a single generic bug.