[webkit-reviews] review granted: [Bug 227234] Web Inspector: Sources: Scope Chain sidebar panel is stripping repeating whitespace from strings : [Attachment 432001] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 227234: Web Inspector: Sources: Scope Chain sidebar panel is stripping
repeating whitespace from strings
https://bugs.webkit.org/show_bug.cgi?id=227234

Attachment 432001: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=432001&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 432001
  --> https://bugs.webkit.org/attachment.cgi?id=432001
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=432001&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +	   which makes sure that the text does not wrap unless it contains a
newline, and these previews have newlines
> +	   replaced with a Unicode symbol to visually represent a newline
without breaking to a new line.

Perhaps worth adding an assertion inside
`WI.FormattedValue.createLinkifiedElementString` that there are no `'\n'` then?