[webkit-reviews] review granted: [Bug 227250] Not all uses of AudioToolbox framework use soft linking : [Attachment 432119] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 23 17:39:09 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jean-yves.avenard at apple.com>'s request for review:
Bug 227250: Not all uses of AudioToolbox framework use soft linking
https://bugs.webkit.org/show_bug.cgi?id=227250

Attachment 432119: Patch

https://bugs.webkit.org/attachment.cgi?id=432119&action=review




--- Comment #11 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 432119
  --> https://bugs.webkit.org/attachment.cgi?id=432119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432119&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:39
> +// WTF_DECLARE_CF_TYPE_TRAIT(CMSampleBuffer);

This should be removed.

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:46
> +// WTF_DECLARE_CF_TYPE_TRAIT(CMSampleBuffer);

Ditto.


More information about the webkit-reviews mailing list