[webkit-reviews] review granted: [Bug 227221] [iOS] Adopt new date picker presentation SPI : [Attachment 431876] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 227221: [iOS] Adopt new date picker presentation SPI
https://bugs.webkit.org/show_bug.cgi?id=227221

Attachment 431876: Patch

https://bugs.webkit.org/attachment.cgi?id=431876&action=review




--- Comment #9 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 431876
  --> https://bugs.webkit.org/attachment.cgi?id=431876
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431876&action=review

>>> Source/WTF/wtf/PlatformHave.h:1061
>>> +#if PLATFORM(IOS_FAMILY) && defined __has_include &&
__has_include(<UIKit/_UIDatePickerOverlayPresentation.h>)
>> 
>> This sort of thing is fragile. We do it when we have to, but in time it
would be good to find something other than the detection of a header in the SDK
to detect this.
> 
> I agree. I went with this approach because the header is relatively new. I
intend to replace the header check with an iOS 15 check in a couple weeks time.
I will file the follow-up bug once this patch is landed.

A `// FIXME: …` referencing a Bugzilla bug might be nice here, in the meantime.