[webkit-reviews] review granted: [Bug 208321] [GTK] media/muted-video-is-playing-audio.html is timing out : [Attachment 432046] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 208321: [GTK] media/muted-video-is-playing-audio.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=208321

Attachment 432046: Patch

https://bugs.webkit.org/attachment.cgi?id=432046&action=review




--- Comment #4 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 432046
  --> https://bugs.webkit.org/attachment.cgi?id=432046
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432046&action=review

LGTM but let's wait until tomorrow to land this and let's ensure the Apple
ports do not regress anything.

> Source/WebCore/testing/Internals.cpp:4821
> +void Internals::setMediaVolume(float volume)

setPageMediaVolume or setPageVolume