[webkit-reviews] review granted: [Bug 227278] Message dropped when restoring webpages. : [Attachment 432018] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 22 22:12:57 PDT 2021
Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 227278: Message dropped when restoring webpages.
https://bugs.webkit.org/show_bug.cgi?id=227278
Attachment 432018: Patch
https://bugs.webkit.org/attachment.cgi?id=432018&action=review
--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 432018
--> https://bugs.webkit.org/attachment.cgi?id=432018
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=432018&action=review
> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:615
> setAppHighlightsVisibility(isVisible ?
WebCore::HighlightVisibility::Visible : WebCore::HighlightVisibility::Hidden);
> };
You could shove this block inline instead of in a local, now, if you wanted.
But this is fine too.
More information about the webkit-reviews
mailing list