[webkit-reviews] review granted: [Bug 227274] Fix incorrect indexing / out of bounds access in getRestartIndices : [Attachment 432008] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 22 17:29:26 PDT 2021


Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 227274: Fix incorrect indexing / out of bounds access in getRestartIndices
https://bugs.webkit.org/show_bug.cgi?id=227274

Attachment 432008: Patch

https://bugs.webkit.org/attachment.cgi?id=432008&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 432008
  --> https://bugs.webkit.org/attachment.cgi?id=432008
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432008&action=review

> Source/ThirdParty/ANGLE/ChangeLog:8
> +	   In the case where a restart index is present in the last element of
an index array, we can accidently
> +	   access out of bounds. Fix this by checking boundaries, and fixing
other indexing errors

Do we need a new test, or did the existing tests pick this up?


More information about the webkit-reviews mailing list