[webkit-reviews] review granted: [Bug 227271] Run lazy properties initializers under a DeferTerminationForAWhile scope : [Attachment 431999] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 227271: Run lazy properties initializers under a DeferTerminationForAWhile
scope
https://bugs.webkit.org/show_bug.cgi?id=227271

Attachment 431999: patch

https://bugs.webkit.org/attachment.cgi?id=431999&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 431999
  --> https://bugs.webkit.org/attachment.cgi?id=431999
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431999&action=review

r=me with fix.

> Source/JavaScriptCore/runtime/LazyPropertyInlines.h:52
> +    static const FuncType theFunc = &callFunc<Func>;
>      m_pointer = lazyTag | bitwise_cast<uintptr_t>(&theFunc);

This looks wrong.  Note use of `bitwise_cast<uintptr_t>(&theFunc)`.