[webkit-reviews] review granted: [Bug 226816] [iOS 15 Regression]: scroll position resets when using scroll snap : [Attachment 431968] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 226816: [iOS 15 Regression]: scroll position resets when using scroll snap
https://bugs.webkit.org/show_bug.cgi?id=226816

Attachment 431968: Patch

https://bugs.webkit.org/attachment.cgi?id=431968&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 431968
  --> https://bugs.webkit.org/attachment.cgi?id=431968
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431968&action=review

r+ but please add a test.

> Source/WebKit/ChangeLog:14
> +	   No new tests because iOS doesn't currently run scroll snap tests
relying on EventSender.

iOS can run touch-based tests with UIScriptController. There are lots in
fast/scrolling/ios

>
Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.
mm:235
> +std::pair<float, std::optional<unsigned>>
RemoteScrollingCoordinatorProxy::closestSnapOffsetForMainFrameScrolling(ScrollE
ventAxis axis, float scrollOrigin, float scrollDestination, float velocity)
const

scrollOrigin is a confusing name. Call it currentScrollOffset?