[webkit-reviews] review granted: [Bug 227188] Add a new pattern to instruction selector to utilize SMADDL supported by ARM64 : [Attachment 431891] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227188: Add a new pattern to instruction selector to utilize SMADDL
supported by ARM64
https://bugs.webkit.org/show_bug.cgi?id=227188

Attachment 431891: Patch

https://bugs.webkit.org/attachment.cgi?id=431891&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 431891
  --> https://bugs.webkit.org/attachment.cgi?id=431891
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431891&action=review

Nice. r=me

> Source/JavaScriptCore/b3/B3LowerToAir.cpp:2548
>	       Air::Opcode multiplyAddOpcode = tryOpcodeForType(MultiplyAdd32,
MultiplyAdd64, m_value->type());

maybe worth an assert the multiple add sign extend is available on the same
platforms as this, otherwise we wouldn't want it inside this if statement.

Maybe: ASSERT(isValidForm(MultiplyAdd64, Arg::Tmp, Arg::Tmp, Arg::Tmp,
Arg::Tmp) == isValidForm(MultiplyAddSignExtend32, Arg::Tmp, Arg::Tmp, Arg::Tmp,
Arg::Tmp))