[webkit-reviews] review granted: [Bug 227204] Add a new pattern to instruction selector to utilize UBFIZ supported by ARM64 : [Attachment 431934] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yijia Huang
<yijia_huang at apple.com>'s request for review:
Bug 227204: Add a new pattern to instruction selector to utilize UBFIZ
supported by ARM64
https://bugs.webkit.org/show_bug.cgi?id=227204

Attachment 431934: Patch

https://bugs.webkit.org/attachment.cgi?id=431934&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 431934
  --> https://bugs.webkit.org/attachment.cgi?id=431934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431934&action=review

Nice. r=me

> Source/JavaScriptCore/b3/B3LowerToAir.cpp:2761
> +		   uint64_t width = static_cast<uint64_t>(WTF::bitCount(mask));

nit: this static cast isn't needed

> Source/JavaScriptCore/b3/B3LowerToAir.cpp:2795
> +		   uint64_t width = static_cast<uint64_t>(WTF::bitCount(mask));

nit: this static_cast isn't needed