[webkit-reviews] review granted: [Bug 227135] [iOS] Update textfield border color to match specification : [Attachment 431864] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 17:37:47 PDT 2021


Maciej Stachowiak <mjs at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 227135: [iOS] Update textfield border color to match specification
https://bugs.webkit.org/show_bug.cgi?id=227135

Attachment 431864: Patch

https://bugs.webkit.org/attachment.cgi?id=431864&action=review




--- Comment #11 from Maciej Stachowiak <mjs at apple.com> ---
Comment on attachment 431864
  --> https://bugs.webkit.org/attachment.cgi?id=431864
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431864&action=review

r=me but see question.

>>>> Source/WebCore/css/html.css:417
>>>> +	  border: 1px solid -apple-system-opaque-separator;
>>> 
>>> It looks like James's suggestion to use -apple-system-separator here
instead has not been applied.
>> 
>> It looks like James's suggestion to use -apple-system-separator here instead
has not been applied.
> 
> We still want an opaque color, hence the use of
"-apple-system-opaque-separator". "-apple-system-separator" is a transparent
color.
> 
> From the other thread, we actually want to use separatorColor composited on
top of a solid color (essentially creating our own opaque separator, since the
UIKit version is currently missing an Increased Contrast variant).
> 
> Consequently, the change that James mentions is actually applied in the
RenderThemeIOS change in the patch, where we now use separatorColor with the
compositing behavior. The name of the CSS value is kept the same to reflect the
opaqueness.

I see! I'm not totally sure how the change in RenderThemeIOS.mm does that. Does
the ", true" force compositing on top of a solid color? Does that handle dark
mode in a reasonable way (as pointed out in another comment in this Radar)?


More information about the webkit-reviews mailing list