[webkit-reviews] review granted: [Bug 227059] rAF driven WebGL submits excessive amount of GPU work when frames are slow : [Attachment 431842] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 227059: rAF driven WebGL submits excessive amount of GPU work when frames
are slow
https://bugs.webkit.org/show_bug.cgi?id=227059

Attachment 431842: Patch

https://bugs.webkit.org/attachment.cgi?id=431842&action=review




--- Comment #13 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 431842
  --> https://bugs.webkit.org/attachment.cgi?id=431842
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431842&action=review

Looks great - unfortunate you had to debug the OpenGL driver issue but let's
move forward. r+

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:65
> +static Seconds maxFrameDuration = 5_s;

Can/should this be const, too?