[webkit-reviews] review granted: [Bug 227227] [Cocoa] iOS device steals BT headphones from other devices during silent playback : [Attachment 431888] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 12:31:35 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 227227: [Cocoa] iOS device steals BT headphones from other devices during
silent playback
https://bugs.webkit.org/show_bug.cgi?id=227227

Attachment 431888: Patch

https://bugs.webkit.org/attachment.cgi?id=431888&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 431888
  --> https://bugs.webkit.org/attachment.cgi?id=431888
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431888&action=review

> Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:100
> +static void setEligibleForSmartRouting(bool eligible)
> +{

Probably worth asserting if this is called on the main thread.


More information about the webkit-reviews mailing list