[webkit-reviews] review granted: [Bug 227092] IndexedDB prints error log about blob files when there is no error : [Attachment 431620] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 21 10:58:31 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 227092: IndexedDB prints error log about blob files when there is no error
https://bugs.webkit.org/show_bug.cgi?id=227092

Attachment 431620: Patch

https://bugs.webkit.org/attachment.cgi?id=431620&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 431620
  --> https://bugs.webkit.org/attachment.cgi?id=431620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431620&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:132
> +    RetainPtr<StoreBlobMessageHandler> handler =
adoptNS([[StoreBlobMessageHandler alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:133
> +    RetainPtr<WKWebViewConfiguration> configuration =
adoptNS([[WKWebViewConfiguration alloc] init]);

auto

> Tools/TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:135
> +    RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc]
initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);

auto


More information about the webkit-reviews mailing list