[webkit-reviews] review granted: [Bug 226948] [JSC] Add ValueOf fast path in toPrimitive : [Attachment 431789] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 226948: [JSC] Add ValueOf fast path in toPrimitive
https://bugs.webkit.org/show_bug.cgi?id=226948

Attachment 431789: Patch

https://bugs.webkit.org/attachment.cgi?id=431789&action=review




--- Comment #4 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 431789
  --> https://bugs.webkit.org/attachment.cgi?id=431789
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431789&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +	       value-of-call	    65.7169+-0.6192	^     45.0986+-0.0830  
     ^ definitely 1.4572x faster

The name of benchmark should probably indicate that it's not just valueOf but
rather "valueOf via toPrimitive".