[webkit-reviews] review granted: [Bug 227160] Functions dispatched to WorkQueue are sometimes destroyed in the calling thread due to block refcounting : [Attachment 431761] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 18 02:54:11 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 227160: Functions dispatched to WorkQueue are sometimes destroyed in the
calling thread due to block refcounting
https://bugs.webkit.org/show_bug.cgi?id=227160

Attachment 431761: Patch

https://bugs.webkit.org/attachment.cgi?id=431761&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 431761
  --> https://bugs.webkit.org/attachment.cgi?id=431761
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431761&action=review

> Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:35
> +namespace {
> +struct DispatchWorkItem {

Could use an empty line here.

> Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:51
> +
> +

Extra empty line here.


More information about the webkit-reviews mailing list