[webkit-reviews] review granted: [Bug 227103] Clear state after process crash so that we know to re-issue sandbox extensions : [Attachment 431745] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 17 17:25:49 PDT 2021


Tim Horton <thorton at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 227103: Clear state after process crash so that we know to re-issue sandbox
extensions
https://bugs.webkit.org/show_bug.cgi?id=227103

Attachment 431745: Patch

https://bugs.webkit.org/attachment.cgi?id=431745&action=review




--- Comment #7 from Tim Horton <thorton at apple.com> ---
Comment on attachment 431745
  --> https://bugs.webkit.org/attachment.cgi?id=431745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431745&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:8201
> -    if (m_preferences->attachmentElementEnabled() &&
!m_process->hasIssuedAttachmentElementRelatedSandboxExtensions()) {
> +    if (m_preferences->attachmentElementEnabled() &&
!process.hasIssuedAttachmentElementRelatedSandboxExtensions()) {

There's other code that uses m_process in this function... is it wrong too??


More information about the webkit-reviews mailing list