[webkit-reviews] review granted: [Bug 227134] [webkitcorepy] Retry downloads in Autoinstall : [Attachment 431693] Patch

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 227134: [webkitcorepy] Retry downloads in Autoinstall
https://bugs.webkit.org/show_bug.cgi?id=227134

Attachment 431693: Patch

https://bugs.webkit.org/attachment.cgi?id=431693&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 431693
  --> https://bugs.webkit.org/attachment.cgi?id=431693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431693&action=review

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:100
> +	       while count <= (AutoInstall.retry or 0):

Do we need 0 here, can we just ensure AutoInstall.retry is always valid?

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:114
> +		       if count > (AutoInstall.retry or 0):

Ditto

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:393
> +    retry = 1

might be better to name it something like: number_of_retry

> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:533
> +    def set_retry(cls, retry):

This method seems unused