[webkit-reviews] review granted: [Bug 227141] AppHighlights disappear on page reload : [Attachment 431706] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 17 12:53:12 PDT 2021

Devin Rousso <drousso at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 227141: AppHighlights disappear on page reload

Attachment 431706: Patch


--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 431706
  --> https://bugs.webkit.org/attachment.cgi?id=431706

View in context: https://bugs.webkit.org/attachment.cgi?id=431706&action=review


> Source/WebCore/page/ChromeClient.h:65
> +#include "HighlightVisibility.h"

Is it really necessary to wrap this in an `#if`?  You could just always include
it and remove the forward-declare below.

> Source/WebKit/Shared/WebPageCreationParameters.h:261
> +    WebCore::HighlightVisibility appHighlightsVisible {
WebCore::HighlightVisibility::Hidden };

Does this need to be set in the UIProcess (e.g.
`WebPageProxy::creationParameters`)?  If not, is it set somewhere else?

More information about the webkit-reviews mailing list