[webkit-reviews] review granted: [Bug 227047] [iOS] Fullscreen video playback gets stuck after interacting with the playback controls : [Attachment 431494] Fix build failures on macOS

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 227047: [iOS] Fullscreen video playback gets stuck after interacting with
the playback controls
https://bugs.webkit.org/show_bug.cgi?id=227047

Attachment 431494: Fix build failures on macOS

https://bugs.webkit.org/attachment.cgi?id=431494&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 431494
  --> https://bugs.webkit.org/attachment.cgi?id=431494
Fix build failures on macOS

View in context: https://bugs.webkit.org/attachment.cgi?id=431494&action=review

> Source/WebCore/platform/cocoa/PlaybackSessionModel.h:105
> +    virtual void rateChanged(bool /* isPlaying */, bool /* isStalled */,
double /* playbackRate */, double /* defaultPlaybackRate */) { }

I agree that an enums and an OptionSet would be nicer than bools