[webkit-reviews] review granted: [Bug 226708] Fix CSS serialization issues affecting css-counter-styles tests : [Attachment 431500] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 17 02:29:55 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 226708: Fix CSS serialization issues affecting css-counter-styles tests
https://bugs.webkit.org/show_bug.cgi?id=226708

Attachment 431500: Patch

https://bugs.webkit.org/attachment.cgi?id=431500&action=review




--- Comment #29 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 431500
  --> https://bugs.webkit.org/attachment.cgi?id=431500
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431500&action=review

> Source/WebCore/css/CSSImageValue.h:45
> +// FIXME: Move to another header? Better name? Should we call this DualURL,
CSSDualURL, CSSParsedURL, or something else?
> +struct DualLocation {
> +    String specifiedURLString;
> +    String resolvedURLString;
> +};

"DualLocation" is a strange name for this. The type represents a single
location after all, in resolved and unresolved form.

The name should have 'URL' in it. CompletedURL would be a good candidate, with
this being the return type of completeURL(). Other alternatives: ResolvedURL,
StyleURL, ...

Why does this use String instead of URL for the members?


More information about the webkit-reviews mailing list