[webkit-reviews] review granted: [Bug 227014] Reimplement JSC::CachePayload without FileSystem::unmapViewOfFile and FileSystem::MappedFileData::leakHandle : [Attachment 431409] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 227014: Reimplement JSC::CachePayload without FileSystem::unmapViewOfFile
and FileSystem::MappedFileData::leakHandle
https://bugs.webkit.org/show_bug.cgi?id=227014

Attachment 431409: Patch

https://bugs.webkit.org/attachment.cgi?id=431409&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 431409
  --> https://bugs.webkit.org/attachment.cgi?id=431409
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431409&action=review

r=me

> Source/JavaScriptCore/runtime/CachePayload.cpp:38
> +    return CachePayload(std::make_pair(WTFMove(data), size));

I think we can use `std::pair { ... }` instead of `make_pair`.

> Source/JavaScriptCore/runtime/CachePayload.cpp:43
> +    return CachePayload(std::make_pair(nullptr, 0));

Ditto.

> Source/JavaScriptCore/runtime/CachePayload.cpp:49
> +    other.m_data = std::make_pair(nullptr, 0);

Ditto.