[webkit-reviews] review granted: [Bug 227102] [Win] TestWTF.WTF_WeakPtr.WeakHashMapIterators is crashing : [Attachment 431627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 16 21:28:29 PDT 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 227102: [Win] TestWTF.WTF_WeakPtr.WeakHashMapIterators is crashing
https://bugs.webkit.org/show_bug.cgi?id=227102

Attachment 431627: Patch

https://bugs.webkit.org/attachment.cgi?id=431627&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 431627
  --> https://bugs.webkit.org/attachment.cgi?id=431627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431627&action=review

> Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp:59
> +    virtual ~Base() { }

Oh, makes sense. Do use ~Base() = default; though.


More information about the webkit-reviews mailing list