[webkit-reviews] review granted: [Bug 227100] Fix crashes in ContentRuleListStore::lookupContentRuleList : [Attachment 431629] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 227100: Fix crashes in ContentRuleListStore::lookupContentRuleList
https://bugs.webkit.org/show_bug.cgi?id=227100

Attachment 431629: Patch

https://bugs.webkit.org/attachment.cgi?id=431629&action=review




--- Comment #12 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 431629
  --> https://bugs.webkit.org/attachment.cgi?id=431629
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431629&action=review

r=me

> Source/WebKit/UIProcess/API/APIContentRuleListStore.cpp:469
> +	       if (!moveFile(legacyPath, path)) {

Are we sure there isn't already a file at the destination path? If there might
be, we likely want to delete it first (in case it is mmap'd).