[webkit-reviews] review denied: [Bug 227076] Passkeys don't work in Simulator : [Attachment 431554] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Garrett Davidson
<garrett_davidson at apple.com>'s request for review:
Bug 227076: Passkeys don't work in Simulator
https://bugs.webkit.org/show_bug.cgi?id=227076

Attachment 431554: Patch

https://bugs.webkit.org/attachment.cgi?id=431554&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 431554
  --> https://bugs.webkit.org/attachment.cgi?id=431554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431554&action=review

r- to change the macro to PLATFORM(IOS_FAMILY_SIMULATOR), but otherwise looks
great.

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:156
>> +#if defined(TARGET_OS_SIMULATOR) && TARGET_OS_SIMULATOR
> 
> I am not familiar with TARGET_OS_SIMULATOR, I see
PLATFORM(IOS_FAMILY_SIMULATOR) used more often. Is there a reason you chose
this instead?

Right -- we don't use these TARGET macros in WebKit. We have PLATFORM macros
that serve this purpose (and handle the defined/not defined state properly).

As Kate suggests, you just want:
#if PLATFORM(IOS_FAMILY_SIMULATOR)