[webkit-reviews] review granted: [Bug 225889] [webkitscmpy] Support branch queries in mock git log : [Attachment 431568] Patch

[bugzilla-daemon at webkit.org]

Stephanie Lewis <slewis at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 225889: [webkitscmpy] Support branch queries in mock git log
https://bugs.webkit.org/show_bug.cgi?id=225889

Attachment 431568: Patch

https://bugs.webkit.org/attachment.cgi?id=431568&action=review




--- Comment #9 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 431568
  --> https://bugs.webkit.org/attachment.cgi?id=431568
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431568&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:532
> +		   if commit.hash.startswith(end) or end == branch:

is it ever passible that the first commit will be in the middle of the range?
This code would treat it as out of range