[webkit-reviews] review denied: [Bug 226992] Break ref cycle between API::HTTPCookieStore and WebKit::WebsiteDataStore : [Attachment 431380] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Sihui Liu
<sihui_liu at apple.com>'s request for review:
Bug 226992: Break ref cycle between API::HTTPCookieStore and
WebKit::WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=226992

Attachment 431380: Patch

https://bugs.webkit.org/attachment.cgi?id=431380&action=review




--- Comment #14 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 431380
  --> https://bugs.webkit.org/attachment.cgi?id=431380
Patch

I think we need to make HTTPCookieStore::m_owningDataStore weak and keep
WebsiteDataStore::m_cookieStore strong. We will need to add a bunch of checks
in HTTPCookieStore, but that makes sense because if the WebsiteDataStore is
destroyed, then there are no more cookies and nothing we can do with them.