[webkit-reviews] review granted: [Bug 227054] Allow WebXR tests to be run on Mac : [Attachment 431501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 16 08:52:11 PDT 2021


Sam Weinig <sam at webkit.org> has granted Ada Chan <adachan at apple.com>'s request
for review:
Bug 227054: Allow WebXR tests to be run on Mac
https://bugs.webkit.org/show_bug.cgi?id=227054

Attachment 431501: Patch

https://bugs.webkit.org/attachment.cgi?id=431501&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 431501
  --> https://bugs.webkit.org/attachment.cgi?id=431501
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431501&action=review

> LayoutTests/TestExpectations:4905
> +# WebXR - expected to fail.

What about these are expected to fail?

> LayoutTests/TestExpectations:4917
> +# rdar://79306047
> +http/wpt/webxr/xrSession_ended_by_system.https.html [ Skip ]

This should probably have a bugzilla in addition to the radar.

> LayoutTests/TestExpectations:4920
> +# rdar://79367325
> +imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https.html [
Skip ]

This should probably have a bugzilla in addition to the radar.


More information about the webkit-reviews mailing list