[webkit-reviews] review granted: [Bug 226870] Nullptr crash in positionInParentBeforeNode via InsertTextCommand::doApply : [Attachment 431515] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 226870: Nullptr crash in positionInParentBeforeNode via
InsertTextCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=226870

Attachment 431515: Patch

https://bugs.webkit.org/attachment.cgi?id=431515&action=review




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 431515
  --> https://bugs.webkit.org/attachment.cgi?id=431515
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431515&action=review

> LayoutTests/ChangeLog:6
> +	   Add regression test.

This should appear after "reviewed by" line.

> Source/WebCore/ChangeLog:7
> +	   deleteSelection call In InsertTextCommand::doApply() can make the
endingSelection() orphan.
> +	   If that happens, exit early to avoid dereferencing a nullptr pointer
later.

This long description should appear below "reviewed by" line while the bug
title & URL should continue to appear above it.