[webkit-reviews] review granted: [Bug 226660] [Metal ANGLE] Shaders with reserved metal keywords do not translate, nor do shaders with struct and variable names that are the same except prefixed by an underscore : [Attachment 431506] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 226660: [Metal ANGLE] Shaders with reserved metal keywords do not
translate, nor do shaders with struct and variable names that are the same
except prefixed by an underscore
https://bugs.webkit.org/show_bug.cgi?id=226660

Attachment 431506: Patch

https://bugs.webkit.org/attachment.cgi?id=431506&action=review




--- Comment #12 from Dean Jackson <dino at apple.com> ---
Comment on attachment 431506
  --> https://bugs.webkit.org/attachment.cgi?id=431506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431506&action=review

>
Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect/RewriteKe
ywords.cpp:159
>	   renamed->setLayoutQualifier(type.getLayoutQualifier());
> +	   
>  

Oops.

> LayoutTests/fast/canvas/webgl/shader-with-reserved-keyword-expected.txt:22
> +PASS successfullyParsed is true
> +
> +TEST COMPLETE
> +PASS getError was expected value: NO_ERROR : no error for using reserved
keyword in struct
> +PASS getError was expected value: NO_ERROR : no error for using reserved
keyword for struct name
> +PASS getError was expected value: NO_ERROR : no error for using reserved
keyword for struct name with global struct
> +PASS getError was expected value: NO_ERROR : no error for using reserved
keyword in type with global struct
> +PASS getError was expected value: NO_ERROR : no error for using reserved
keyword for struct name  with global struct
> +PASS getError was expected value: NO_ERROR : no error for using reserved
keyword for variable name with global struct
> +PASS getError was expected value: NO_ERROR : no error for using reserved
keyword for variable name and struct name with global struct

I'm not sure why the test output is coming after the test complete message. I
think it's because you're using the webgl test utils but also mixing it with
the WebKit utils.

> LayoutTests/fast/canvas/webgl/shader-with-reserved-keyword.html:22
> +	   console.log(gl.getShaderInfoLog(fragmentShader));

I think you left this in by accident.