[webkit-reviews] review granted: [Bug 227052] AssemblyHelpers should save/restore callee save FPRs : [Attachment 431499] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 227052: AssemblyHelpers should save/restore callee save FPRs
https://bugs.webkit.org/show_bug.cgi?id=227052

Attachment 431499: Patch

https://bugs.webkit.org/attachment.cgi?id=431499&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 431499
  --> https://bugs.webkit.org/attachment.cgi?id=431499
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431499&action=review

r=me with ChangeLog fixes.

> Source/JavaScriptCore/ChangeLog:9
> +	   We have 3 functions in AssemblyHelpers to save and restore callee
save registers that were filtering

4 functions (according to this patch), not 3.

> Source/JavaScriptCore/ChangeLog:10
> +	   out any FPRs. This is an issue since we do have callee save FPRs in
arm64 and these helpers can be

/these helpers can be/there are helpers/?  Otherwise, it's not clear which
helpers the "these helpers" refer to.

> Source/JavaScriptCore/ChangeLog:11
> +	   called from the FTL, which uses those callee saves. The test case
shows how that's an issue with tail

remove the ',' to go with the above edit?