[webkit-reviews] review granted: [Bug 227033] Cleanup RenderElement::RendererCreationType : [Attachment 431471] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 227033: Cleanup RenderElement::RendererCreationType
https://bugs.webkit.org/show_bug.cgi?id=227033

Attachment 431471: Patch

https://bugs.webkit.org/attachment.cgi?id=431471&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 431471
  --> https://bugs.webkit.org/attachment.cgi?id=431471
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431471&action=review

> Source/WebCore/rendering/RenderElement.cpp:189
> +	   if
(rendererTypeOverride.contains(ConstructBlockLevelRendererFor::TableTypes))
>	       return createRenderer<RenderBlockFlow>(element, WTFMove(style));

Is this entire 'default' block about table types? Seems like it would better to
explicitly check for a table display type here?