[webkit-reviews] review granted: [Bug 204686] [GStreamer] Refactor MediaPlayerPrivateGStreamer::notifyPlayerOf* : [Attachment 431448] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 204686: [GStreamer] Refactor MediaPlayerPrivateGStreamer::notifyPlayerOf*
https://bugs.webkit.org/show_bug.cgi?id=204686

Attachment 431448: Patch

https://bugs.webkit.org/attachment.cgi?id=431448&action=review




--- Comment #4 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 431448
  --> https://bugs.webkit.org/attachment.cgi?id=431448
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431448&action=review

Nice clean-up!

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1050
> +	   addTrackToPlayer(*m_player, track.get());

Nit: I wonder if instead of static funcs we could use a Variant on the enum
value here?