[webkit-reviews] review granted: [Bug 227013] Move setting of scratch buffer active lengths to the runtime functions. : [Attachment 431404] proposed patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 15 08:34:27 PDT 2021
Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 227013: Move setting of scratch buffer active lengths to the runtime
functions.
https://bugs.webkit.org/show_bug.cgi?id=227013
Attachment 431404: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=431404&action=review
--- Comment #4 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 431404
--> https://bugs.webkit.org/attachment.cgi?id=431404
proposed patch.
r=me. How do we get the scratch register buffer when writing to it in C++? If
it’s not via the m_scratchBuffer member maybe we should have an assert that
it’s set?
More information about the webkit-reviews
mailing list