[webkit-reviews] review canceled: [Bug 226266] Add LLInt fast path for less, lesseq, greater and greatereq : [Attachment 431090] Patch

[bugzilla-daemon at webkit.org]

Caio Lima <ticaiolima at gmail.com> has canceled Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 226266: Add LLInt fast path for less, lesseq, greater and greatereq
https://bugs.webkit.org/show_bug.cgi?id=226266

Attachment 431090: Patch

https://bugs.webkit.org/attachment.cgi?id=431090&action=review




--- Comment #22 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 431090
  --> https://bugs.webkit.org/attachment.cgi?id=431090
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431090&action=review

LGTM as well. Since Tadeu gave you a r+ already, following patches you don’t
need to set “r?" again, only if you made a major changes from previous patch.
Ping me when you think patch is ready to get cq+.

> Source/JavaScriptCore/ChangeLog:9
> +	   in LLInt, so we donât need to go to slow path for those cases.

nit: there’s a strange character here.

> Source/JavaScriptCore/ChangeLog:12
> +	   instruction for ARMv7, MIPS and CLoop.

Could you include the numbers of benchmarks here? Also, it’s important to
highlight that those numbers are from a LLInt-only configuration.